D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

poboiko added a comment. In D23008#508782 , @bruns wrote: > @poboiko - is the problem you describe purely theoretical, or did you actually see it happen? > > Multiple triggers of `slotNewInput` are **not** a problem, the code flow reaches

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

bruns added a comment. @poboiko - is the problem you describe purely theoretical, or did you actually see it happen? Multiple triggers of `slotNewInput` are **not** a problem, the code flow reaches the `m_tr = new Transaction(...)` only iff a batch has been read. And batches are only

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

poboiko added inline comments. INLINE COMMENTS > anthonyfieroni wrote in app.cpp:76-81 > processNextFile should be called till m_ids ends, why it does not happen, > probably that's why @bruns reject your patch Well, if that happens, something went wrong, and we have to do something. As far as

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

anthonyfieroni added inline comments. INLINE COMMENTS > app.cpp:76-81 > +if (m_tr) { > +// Parent proccess yielded us a new batch while previous have not > yet finished > +// This should not happen, but better play safe > +m_tr->commit(); > +delete m_tr; >

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23008 To: poboiko, #baloo, bruns, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh,

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I can't reproduce the issue either, but this doesn't seem to cause any regressions that I can see, and the code makes sense to me. REPOSITORY R293 Baloo BRANCH extractor-transaction

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

broulik added inline comments. INLINE COMMENTS > ngraham wrote in app.h:50 > This isn't public to outside users, right? It doens't have an EXPORT macro to it, so I suppose not? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23008 To: poboiko, #baloo, bruns, ngraham

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

ngraham added inline comments. INLINE COMMENTS > app.h:50 > public: > -explicit App(QObject* parent = nullptr); > This isn't public to outside users, right? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23008 To: poboiko, #baloo, bruns, ngraham Cc:

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY When a new batch arrives at stdin (as notified by QSocketNotifier), extractor creates a new transaction. If