dfaure closed this revision.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D23108
To: dfaure, broulik, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.
Looks good to me.
REPOSITORY
R278 KWindowSystem
BRANCH
setmainwindow
REVISION DETAIL
https://phabricator.kde.org/D23108
To: dfaure, broulik, davidedmundson, zzag
Cc: kde-frameworks-deve
dfaure updated this revision to Diff 64270.
dfaure marked an inline comment as done.
dfaure added a comment.
Fix memory leak in new overload
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23108?vs=63893&id=64270
BRANCH
setmainwindow
REVISION DETAI
dfaure marked 3 inline comments as done.
dfaure added inline comments.
INLINE COMMENTS
> zzag wrote in kwindowsystem.cpp:490
> Each time this method is called a new foreign QWindow object will be created.
> Can you please explain why leaking those objects is okay?
Ah I didn't realize that QWind
zzag added inline comments.
INLINE COMMENTS
> kwindowsystem.cpp:458
>
> +static QWindow* setMainWindowHelper(QWindow *subWindow, WId mainWindowId)
> +{
Coding style: For pointers or references, use a single space before '*' or '&',
but not after.
https://techbase.kde.org/Policies/Frameworks_
dfaure updated this revision to Diff 63893.
dfaure added a comment.
Adjust documentation
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23108?vs=63597&id=63893
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23108
AFFECTED FILES
sr
zzag added inline comments.
INLINE COMMENTS
> kwindowsystem.h:233
> * when the parent is deleted are unaffected and normally use
> * the QWidget parent.
> *
> and normally use the QWidget parent.
I think this statement is inaccurate. Documentation needs more love. :-)
REPOSIT
dfaure created this revision.
dfaure added reviewers: broulik, davidedmundson, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
All QWidget-based API is now deprecated in this module.
TEST PLAN
