D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-14 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R266:c8ebfc2530dd: Fix missing digit and pixel-perfect alignment of depth action icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D23116#511480 , @trickyricky26 wrote: > I thought about that, too, and while the red used in the icon is exactly `NegativeText`, the blue

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread TrickyRicky
trickyricky26 added a comment. In D23116#511430 , @GB_2 wrote: > Maybe instead of hardcoding the blue and red colors you can use the stylesheet colors `ButtonFocus` and `NegativeText`:

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread Björn Feber
GB_2 added a comment. Maybe instead of hardcoding the blue and red colors you can use the stylesheet colors `ButtonFocus` and `NegativeText`: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets REPOSITORY R266 Breeze Icons REVISION DETAIL

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread TrickyRicky
trickyricky26 marked 4 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23116 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread TrickyRicky
trickyricky26 updated this revision to Diff 63652. trickyricky26 added a comment. - Fix stylesheet ids REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23116?vs=63626=63652 BRANCH fix-depth-icons (branched from master) REVISION DETAIL

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-12 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Not having `id="current-color-scheme"` causes stylesheets to not work correctly. INLINE COMMENTS > depth16to8.svg:1 > -http://www.w3.org/2000/svg; viewBox="0 0 22 22"> > - > -

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-12 Thread Nathaniel Graham
ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. `FIXED-IN: ` refers to the next release (i.e. the one that this fix will make it into). The latest released version of KDE Frameworks is 5.61,

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23116 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-12 Thread TrickyRicky
trickyricky26 added a comment. I am not quite sure of the version for the FIXED-IN tag. Also, this bug was reported in digikam running on Windows 10, are there any additional steps necessary to get this change from breeze-icons to the digikam Windows build? REPOSITORY R266 Breeze

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-12 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23116 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-12 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23116 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n,

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-12 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-depth-icons (branched from master) REVISION DETAIL