This revision was automatically updated to reflect the committed changes.
Closed by commit R216:635cb83670f9: Use CMake find_dependency in CMake config
file instead of find_package (authored by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
cgiboudeaux accepted this revision.
REVISION DETAIL
https://phabricator.kde.org/D23208
To: daandemeyer, #framework_syntax_highlighting, dhaumann, cgiboudeaux
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad,
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demskin
daandemeyer marked an inline comment as done.
REVISION DETAIL
https://phabricator.kde.org/D23208
To: daandemeyer, #framework_syntax_highlighting, dhaumann
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad,
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking,
daandemeyer updated this revision to Diff 63914.
daandemeyer added a comment.
Use `REQUIRED_QT_VERSION` to specifiy required Qt version.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23208?vs=63877&id=63914
REVISION DETAIL
https://phabricator.kde.org/D23208
AFFECTED FILES
KF5S
cgiboudeaux added inline comments.
INLINE COMMENTS
> KF5SyntaxHighlightingConfig.cmake.in:4-5
> +include(CMakeFindDependencyMacro)
> +find_dependency(Qt5Core @Qt5Core_VERSION_MAJOR@.@Qt5Core_VERSION_MINOR@)
> +find_dependency(Qt5Gui @Qt5Core_VERSION_MAJOR@.@Qt5Core_VERSION_MINOR@)
>
Please use
dhaumann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23208
To: daandemeyer, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmorti
daandemeyer created this revision.
daandemeyer added a reviewer: Framework: Syntax Highlighting.
daandemeyer added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
daandemeyer requested review of this r
