D23214: Add a BlockinApp util class to find process blockng access

[David Hallas]

hallas added a comment.


  In D23214#513408 , @meven wrote:
  
  > In D23214#513396 , @hallas wrote:
  >
  > > Hey @meven I have been working on the same thing D21760 
 - maybe we should consolidate our efforts? 
The code you have written looks very similar to what I have been doing :) As 
you can read in the review comments for D21760 
 the current suggestion is to look into 
doing a KJob subclass.
  >
  >
  > Great suggestion I missed this prior diff.
  >
  > Abandoned in favor of D21760  and 
adding a KJob for this use case
  
  
  I am currently working on re-working the code to derive from KJob, will post 
an updated patch soon :) Also, please take a look at the code and come with 
review comments/suggestions :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23214

To: meven, davidedmundson, #frameworks
Cc: hallas, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

[Méven Car]

meven abandoned this revision.
meven added a comment.


  In D23214#513396 , @hallas wrote:
  
  > Hey @meven I have been working on the same thing D21760 
 - maybe we should consolidate our efforts? 
The code you have written looks very similar to what I have been doing :) As 
you can read in the review comments for D21760 
 the current suggestion is to look into 
doing a KJob subclass.
  
  
  Great suggestion I missed this prior diff.
  
  Abandoned in favor of D21760  and adding 
a KJob for this use case

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23214

To: meven, davidedmundson, #frameworks
Cc: hallas, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

[David Hallas]

hallas added a comment.


  Hey @meven I have been working on the same thing D21760 
 - maybe we should consolidate our efforts? 
The code you have written looks very similar to what I have been doing :) As 
you can read in the review comments for D21760 
 the current suggestion is to look into 
doing a KJob subclass.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23214

To: meven, davidedmundson, #frameworks
Cc: hallas, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

[Méven Car]

meven updated this revision to Diff 63911.
meven added a comment.


  Add copyright

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23214?vs=63910=63911

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23214

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/util/blockingapp.cpp
  src/lib/util/blockingapp.h
  tests/CMakeLists.txt
  tests/testblockingapp.cpp

To: meven, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

[Méven Car]

meven created this revision.
meven added reviewers: davidedmundson, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Uses lsof and kprocesslist to extract names of process blocking on the given 
files.
  
  It is a port over from ksolidnotify.h of plasma-workspace to allow broader 
use.
  
  CC D19989 

TEST PLAN
  Using testBlockingApp test

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23214

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/util/blockingapp.cpp
  src/lib/util/blockingapp.h
  tests/CMakeLists.txt
  tests/testblockingapp.cpp

To: meven, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns