This revision was automatically updated to reflect the committed changes.
Closed by commit R216:63719f49867b: LESS: import CSS keywords, new highlighting
and some improvements (authored by jpoelen).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D23278?vs=64078&id=64182#toc
REPOSITORY
R
jpoelen added a comment.
The other files that use the include statement are also in version 5.53.
If highlightingindexer adds a version check, it is also necessary to check
that the included files are of the same or lower version. Ideally, this should
also be done for IncludeRules.
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Lgtm.
Btw, do all highlighting files using the include statement in lists use
kateversion="5.53"? If not, we should fix it. In fact, we should extend our
highlightingindexer to che
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23278
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, micha
jpoelen created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
jpoelen requested review of this revision.
REVISION SUMMARY
New highlighting (same as CSS):
- Value Keyword
- Color
- Number
- Unit
Improvements a
