D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:ee5c3d12f965: add `-pid` parameter to Snore backend calls 
(authored by brute4s99).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64111=64112

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal 
brute4s99 updated this revision to Diff 64111.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64110=64111

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal 
brute4s99 updated this revision to Diff 64110.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64085=64110

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal 
brute4s99 added a comment.


  had some non-unix line endings, so updated the diff.

REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal 
brute4s99 added a comment.


  landing it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Hannah von Reth 
vonreth accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

2019-08-19 Thread Piyush Aggarwal 
brute4s99 added a dependency: D23273: Allow to pass pid in addition to appID 
try to deduce appID from pid.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks
Cc: kde-frameworks-devel, vonreth, LeGast00n, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

2019-08-19 Thread Piyush Aggarwal 
brute4s99 created this revision.
brute4s99 added reviewers: KDE Connect, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  the upcoming change to SnoreToast also accepts `process id`. Since we can 
supply PID, why not? :)

REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks
Cc: kde-frameworks-devel, vonreth, LeGast00n, michaelh, ngraham, bruns