D23367: make the sizing of the toolbuttons more coherent

This revision was automatically updated to reflect the committed changes. Closed by commit R242:069b4e95c155: make the sizing of the toolbuttons more coherent (authored by camiloh). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=648

D23367: make the sizing of the toolbuttons more coherent

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23367 REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2,

D23367: make the sizing of the toolbuttons more coherent

camiloh updated this revision to Diff 64844. camiloh added a comment. make the icon fill height and width if the icon group height or width props are not set or are 0 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=64832&id=64844

D23367: make the sizing of the toolbuttons more coherent

camiloh updated this revision to Diff 64832. camiloh added a comment. make usage of the icon group properties: height and width REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=64449&id=64832 BRANCH arcpatch-D23367 REVISION DET

D23367: make the sizing of the toolbuttons more coherent

mart added inline comments. INLINE COMMENTS > ToolButton.qml:49 > + > +Item { > +Layout.preferredWidth: Kirigami.Units.iconSizes.smallMedium + > Kirigami.Units.largeSpacing this further item enclosing is not necessary, is an object instantation more for no functional gain

D23367: make the sizing of the toolbuttons more coherent

mart added a comment. In D23367#517658 , @ngraham wrote: > Not that it's an inappropriate fix, but are you sure you want to be using PlasmaComponents ToolButtons in Index? Why not use regular old QQC2 ToolButtons? The phone is using the p

D23367: make the sizing of the toolbuttons more coherent

mart requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraha

D23367: make the sizing of the toolbuttons more coherent

mart reopened this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23367: make the sizing of the toolbuttons more coherent

mart added inline comments. INLINE COMMENTS > ToolButton.qml:56 > +anchors.centerIn: parent > +height: Kirigami.Units.iconSizes.smallMedium > +width: Kirigami.Units.iconSizes.smallMedium This fixes the icons to a single size no matter what, and we

D23367: make the sizing of the toolbuttons more coherent

broulik added a comment. This breaks the sizing of larger buttons like in media controller: F7288011: Screenshot_20190828_100935.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasm

D23367: make the sizing of the toolbuttons more coherent

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3887f5ec9152: make the sizing of the toolbuttons more coherent (authored by camiloh). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=644

D23367: make the sizing of the toolbuttons more coherent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I see, that's just a test. LGTM! REPOSITORY R242 Plasma Framework (Library) BRANCH toolbutton-icon-sizing (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D23367: make the sizing of the toolbuttons more coherent

camiloh added a comment. In D23367#517658 , @ngraham wrote: > Not that it's an inappropriate fix, but are you sure you want to be using PlasmaComponents ToolButtons in Index? Why not use regular old QQC2 ToolButtons? My intention with the

D23367: make the sizing of the toolbuttons more coherent

ngraham added a comment. Not that it's an inappropriate fix, but are you sure you want to be using PlasmaComponents ToolButtons in Index? Why not use regular old QQC2 ToolButtons? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh,

D23367: make the sizing of the toolbuttons more coherent

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23367: make the sizing of the toolbuttons more coherent

camiloh updated this revision to Diff 64432. camiloh marked an inline comment as done. camiloh added a comment. if parent is nto visible then children are not visible. fix REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=64368&id=6

D23367: make the sizing of the toolbuttons more coherent

camiloh marked an inline comment as done. camiloh added inline comments. INLINE COMMENTS > apol wrote in ToolButton.qml:56 > That's always the case, isn't it? if a parent isn't visible, an item will > never be visible. yes. you're right. REPOSITORY R242 Plasma Framework (Library) REVISION D

D23367: make the sizing of the toolbuttons more coherent

apol added inline comments. INLINE COMMENTS > ToolButton.qml:56 > +anchors.centerIn: parent > +visible: parent.visible > +height: Kirigami.Units.iconSizes.smallMedium That's always the case, isn't it? if a parent isn't visible, an item will never

D23367: make the sizing of the toolbuttons more coherent

camiloh created this revision. camiloh added reviewers: Plasma, mart, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. camiloh requested review of this revision. REVISION SUMMARY this makes the toolbutton icons follow a standard size. Maybe one coul