D23388: add a border for the toolbars WIP

GB_2 added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

mart added inline comments. INLINE COMMENTS > ToolBar.qml:47 > +bottom: control.position == T.ToolBar.Footer || > (control.parent.footer && control.parent.footer == control) ? undefined : > parent.bottom > +} > +} for now you need for now to add there: Kirig

D23388: add a border for the toolbars WIP

apol added a comment. Well it's the same color, it just looks okay. Set the applications' color scheme to another one and you'll see what I mean. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: k

D23388: add a border for the toolbars WIP

camiloh added a comment. In D23388#517778 , @apol wrote: > I don't think we can use Kirigami here, it will use the wrong color scheme. You'll have to copy over the Separator's rectangle. It seems to take the right color: In the followin

D23388: add a border for the toolbars WIP

apol added a comment. I don't think we can use Kirigami here, it will use the wrong color scheme. You'll have to copy over the Separator's rectangle. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol C

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

ngraham added a comment. Huge +1 on the visuals. I'll let someone else review this for technical correctness. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

ngraham added a comment. Before-and-after pictures would be appreciated. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

camiloh retitled this revision from "add a border for the toolbars" to "add a border for the toolbars WIP". camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc

D23388: add a border for the toolbars

camiloh created this revision. camiloh added reviewers: Plasma, mart, ngraham, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. camiloh requested review of this revision. REVISION SUMMARY this is mostly mean for the QQC2 apps running on PlaMo and using t