astippich added a comment.
Thanks! I pushed a fix which disables the test if taglib is not installed
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D23411
To: astippich, bruns, mgallien, ngraham
Cc: justinkb, apol, kde-frameworks-devel, #baloo, hurikhan77, lots
justinkb added a comment.
The test incorrectly fails when a user builds kfilemetadata without taglib
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D23411
To: astippich, bruns, mgallien, ngraham
Cc: justinkb, apol, kde-frameworks-devel, #baloo, hurikhan77, lots
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:494b068af264: Fix crash in writer collection and cleanup
(authored by astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23411?vs=67376&id=67443
REVI
astippich updated this revision to Diff 67376.
astippich added a comment.
- actually add test file for writercollection
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23411?vs=67372&id=67376
BRANCH
fixWriterCollection
REVISION DETAIL
https://pha
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
fixWriterCollection
REVISION DETAIL
https://phabricator.kde.org/D23411
To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n,
astippich updated this revision to Diff 67372.
astippich added a comment.
- improve
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23411?vs=64543&id=67372
BRANCH
fixWriterCollection
REVISION DETAIL
https://phabricator.kde.org/D23411
AFFECTED FI
astippich added a comment.
ping!
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D23411
To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas,
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun
astippich added a comment.
friendly ping. Since this solves a crash and I want to start using the
writers in Elisa, I would like to have it rather sooner in a frameworks release
and I'm away the next weeks
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D23411
astippich added inline comments.
INLINE COMMENTS
> apol wrote in writer.h:63
> Why's this change?
This is only for cleanup and consistency with the corresponding extractor class.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D23411
To: astippich, bruns, mgallie
bruns added inline comments.
INLINE COMMENTS
> apol wrote in writercollection.cpp:133
> maybe it would make sense to use shared pointers there?
No. `m_plugin` is either a QPluginLoader::instance(), i.e. shared, or a
collection-owned ExternalWriter.
REPOSITORY
R286 KFileMetaData
REVISION DET
apol added inline comments.
INLINE COMMENTS
> writer.h:63
>
> +WriterPrivate *d;
> friend class WriterCollection;
Why's this change?
> writercollection.cpp:133
> +Writer writer;
> +writer.d->m_plugin = plugin;
> +writer.setAutoDeletePlugin(Writer::AutoDeletePl
astippich added a comment.
ping
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D23411
To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson,
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
astippich updated this revision to Diff 64543.
astippich added a comment.
- further improvements
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23411?vs=64514&id=64543
BRANCH
fixWriterCollection
REVISION DETAIL
https://phabricator.kde.org/D23411
astippich created this revision.
astippich added reviewers: bruns, mgallien, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
WriterCollection was apparently never used.
It cr
14 matches
Mail list logo
