D23464: Add breeze icons for ROOT cern files

This revision was automatically updated to reflect the committed changes. Closed by commit R266:018b67eff94c: Add breeze icons for ROOT cern files (authored by Marc Henning marc.henni...@rwth-aachen.de, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D23464: Add breeze icons for ROOT cern files

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde added a comment. In D23464#524994 , @ndavis wrote: > Looks like you've got everything Thank you all for mentoring me! :) REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

ndavis added a comment. Looks like you've got everything REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23464: Add breeze icons for ROOT cern files

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n,

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 65307. alexde added a comment. 16px: add 2px margins to top and bottom 22px: add 3px margins to top and bottom 32px: use existing and approved 32px icon as template instead of shrinking the 64px version REPOSITORY R266 Breeze Icons CHANGES SINCE

D23464: Add breeze icons for ROOT cern files

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. You're getting there. - 16px: needs 2px margins on the top and bottom - 22px: needs 3px margins on the top and bottom - 32px: needs to be lined up with the pixel grid and

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 65264. alexde edited the test plan for this revision. alexde added a comment. Remove all circles and only use root symbol. This makes the root symbol less faint and the icons fit better to Breeze overall. REPOSITORY R266 Breeze Icons CHANGES SINCE

D23464: Add breeze icons for ROOT cern files

ngraham added a comment. If the 16px and 22px versions include the ring, then it needs to be in the larger versions as well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis,

D23464: Add breeze icons for ROOT cern files

ndavis added a comment. In D23464#522459 , @alexde wrote: > In D23464#522270 , @trickyricky26 wrote: > > > As @noahdvs mentioned above, the white background should be removed and the entire symbol

D23464: Add breeze icons for ROOT cern files

alexde added a reviewer: ngraham. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde added a comment. In D23464#522270 , @trickyricky26 wrote: > As @noahdvs mentioned above, the white background should be removed and the entire symbol should be made up of one filled path with no outline (!). This is important to keep

D23464: Add breeze icons for ROOT cern files

trickyricky26 added a comment. My thoughts on your submission: For the 16px and 22px designs, I would with the designs @ndavis proposed here: In D23464#521662 , @ndavis wrote: > F7290924: mimetypes.tar.gz

D23464: Add breeze icons for ROOT cern files

alexde added a comment. > The 16 and 22 px versions aren't supposed to have backgrounds and the root symbols are pretty faint. Rethinking it, I think it's wrong. The white background belongs to the logo and should not be removed as the white circle and the root symbol belong together,

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 64946. alexde added a comment. Add new 32px icons. The root is now less faint and uses the original color. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64944=64946 BRANCH ROOT (branched from

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 64944. alexde added a comment. Also add the new 64px breeze icon. Add new 22 px icons. Transparent background, less faint, original color. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64935=64944

D23464: Add breeze icons for ROOT cern files

alexde added a comment. In D23464#521662 , @ndavis wrote: > I think we should use `#1ed4e5` for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a mess

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 64935. alexde added a comment. Improve the root logo layout and change the root's color to the offical color 1ED4E5 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64668=64935 BRANCH ROOT (branched from

D23464: Add breeze icons for ROOT cern files

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I think we should use `#1ed4e5` for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a

D23464: Add breeze icons for ROOT cern files

alexde edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL