kossebau added inline comments.
INLINE COMMENTS
> kossebau wrote in normalvimode.cpp:3844
> Ah, no, textLines.last().length() needs the string section, so just a plain
> count would not be enough, only if combining with a QString::section call
> later, I now remember.
> And some other patch
kossebau added inline comments.
INLINE COMMENTS
> kossebau wrote in normalvimode.cpp:3844
> Guess the complete change missed to enter the commit, and review did not
> catch it,
> Well spotted, I shall do a follow-up.
Ah, no, textLines.last().length() needs the string section, so just a plain
kossebau added inline comments.
INLINE COMMENTS
> apol wrote in normalvimode.cpp:3844
> you didn't port this one to count?
Guess the complete change missed to enter the commit, and review did not catch
it,
Well spotted, I shall do a follow-up.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
apol added inline comments.
INLINE COMMENTS
> normalvimode.cpp:3844
> KTextEditor::Cursor cAfter = pasteLocation;
> -const QStringList textLines = pastedText.split(QStringLiteral("\n"));
> +const QStringList textLines = pastedText.split(QLatin1Char('\n'));
> if
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:a5783ba11943: Use QString::count(QChar) over
QString::split().length() - 1 (authored by kossebau).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Looks reasonable, thanks.
REPOSITORY
R39 KTextEditor
BRANCH
usecount
REVISION DETAIL
https://phabricator.kde.org/D23625
To: kossebau, #kate, cullmann
Cc: cullmann,
kossebau created this revision.
kossebau added a reviewer: Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.
REPOSITORY
R39 KTextEditor
BRANCH
usecount
REVISION DETAIL
