D23627: Make notification icons use outline style

2019-09-03 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:db7837d5f5c1: Make notification icons use outline style 
(authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23627?vs=65102&id=65332

REVISION DETAIL
  https://phabricator.kde.org/D23627

AFFECTED FILES
  src/desktoptheme/breeze/icons/notification.svg

To: ndavis, #vdg, #plasma, ngraham
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23627: Make notification icons use outline style

2019-09-03 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma, ngraham
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis 
ndavis added a dependent revision: D23658: Make notification icons use outline 
style.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis 
ndavis added a comment.


  I could use a modified version of the KAlarm systray icon F7307137: 
Screenshot_20190901_212547.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Nathaniel Graham 
ngraham added a comment.


  Maybe leave the clapper alone for now then? +1 on making it outline style at 
least.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis 
ndavis added a comment.


  In D23627#523987 , @ngraham wrote:
  
  > I kinda like the off-center clapper, but I understand how it might drive 
OCD people mildly insane. :) However the full-color icon theme notification 
preferences icon has an off-center clapper, so I think if we're going to make 
that change here, we need to do it there too.
  >
  > Having said this, a centered clapper looks a bit odd to me. I wonder... so 
we even need it at all? The bell is still plenty recognizable as a bell without 
it. Maybe experiment with removing it entirely?
  
  
  I'd have to remake the whole bell shape so that the icon doesn't look weirdly 
short.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Nathaniel Graham 
ngraham added a comment.


  I kinda like the off-center clapper, but I understand how it might drive OCD 
people mildly insane. :) However the full-color icon theme notification 
preferences icon has an off-center clapper, so I think if we're going to make 
that change here, we need to do it there too.
  
  Having said this, a centered clapper looks a bit odd to me. I wonder... so we 
even need it at all? The bell is still plenty recognizable as a bell without 
it. Maybe experiment with removing it entirely?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Filip Fila 
filipf added a comment.


  +1, looks good, thanks for centering the clapper as well

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis 
ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  They didn't quite fit in with the filled style

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23627

AFFECTED FILES
  src/desktoptheme/breeze/icons/notification.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns