D23667: Add == and != operators to KIO::UDSEntry

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f893784ea4f1: Add == and != operators to KIO::UDSEntry (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=66086=66883 REVISION DETAIL

D23667: Add == and != operators to KIO::UDSEntry

dfaure added a comment. Note that there is `KFileItem::cmp` for a more thorough comparison of two fileitems. But it only looks at some UDS fields -- those that matter at the KDirLister level. Or maybe it shows that UDSEntry::operator== was missing so KFileItem::cmp uses a poor man's

D23667: Add == and != operators to KIO::UDSEntry

meven added a comment. In D23667#535222 , @dfaure wrote: > Looks ok, but I'm just curious about the use case. "I felt it was missing" doesn't sound as strong an argument as "I need this"... > > Slaves are supposed to mostly create those, not

D23667: Add == and != operators to KIO::UDSEntry

dfaure accepted this revision. dfaure added a comment. Looks ok, but I'm just curious about the use case. "I felt it was missing" doesn't sound as strong an argument as "I need this"... Slaves are supposed to mostly create those, not compare them, and apps are supposed to use KFileItem

D23667: Add == and != operators to KIO::UDSEntry

meven added a comment. @pino if this is fine for you... REPOSITORY R241 KIO BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks, ngraham Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 66086. meven added a comment. Update @since references REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65705=66086 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65705. meven added a comment. Remove unneeded friend function declarations REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65608=65705 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65608. meven marked 5 inline comments as done. meven added a comment. typo fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65607=65608 BRANCH arcpatch-D23667 REVISION DETAIL

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65607. meven added a comment. Fix test and implementation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65298=65607 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES

D23667: Add == and != operators to KIO::UDSEntry

pino added a comment. please use `QCOMPARE`/`QVERIFY` instead of `Q_ASSERT` in QTest tests INLINE COMMENTS > udsentrytest.cpp:301 > + > +// 4th entry : an additionnal field > +KIO::UDSEntry entry4; typo, "additional" REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D23667: Add == and != operators to KIO::UDSEntry

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks, ngraham Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65298. meven added a comment. fix since mention REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65297=65298 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES

D23667: Add == and != operators to KIO::UDSEntry

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65297. meven added a comment. Fix test udsentrybenchmark REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65296=65297 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65296. meven added a comment. Clean spaces changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65295=65296 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65295. meven added a comment. Move impl to cpp file, fix comment, add unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65218=65295 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667

D23667: Add == and != operators to KIO::UDSEntry

pino added a comment. Oh, and also please add tests for them in UDSEntryTest. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

pino added a comment. Please move the implementations in the cpp file, otherwise it will be impossible to change/fix the implementation later on in a binary compatible way. Also: - both the operators ought to be const, since they do not mutate the object (and otherwise they cannot

D23667: Add == and != operators to KIO::UDSEntry

ngraham added a comment. I know it seems silly for such tiny functions, but can you follow the pattern and keep only the function definitions in the header file and move the actual logic into the .cpp file? INLINE COMMENTS > udsentry.h:118 > +/** > + * Returns true if the entry

D23667: Add == and != operators to KIO::UDSEntry

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY I felt it was missing. TEST PLAN Compiles REPOSITORY R241 KIO BRANCH master