D23713: strongswan support for custom proposals
This revision was automatically updated to reflect the committed changes. Closed by commit R116:9d88ac7082cf: strongswan support for custom proposals (authored by rrichmond, committed by aacid). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23713?vs=65799=65969#toc REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23713?vs=65799=65969 REVISION DETAIL https://phabricator.kde.org/D23713 AFFECTED FILES vpn/strongswan/nm-strongswan-service.h vpn/strongswan/strongswanprop.ui vpn/strongswan/strongswanwidget.cpp To: rrichmond, fvogt, jgrulich Cc: plasma-devel, pino, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, michaelh, ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23713: strongswan support for custom proposals
jgrulich accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23713: strongswan support for custom proposals
rrichmond updated this revision to Diff 65799. rrichmond added a comment. Custom proposals unchecked by default. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23713?vs=65711=65799 REVISION DETAIL https://phabricator.kde.org/D23713 AFFECTED FILES plasma-nm-5.15.5/vpn/strongswan/nm-strongswan-service.h plasma-nm-5.15.5/vpn/strongswan/strongswanprop.ui plasma-nm-5.15.5/vpn/strongswan/strongswanwidget.cpp To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23713: strongswan support for custom proposals
jgrulich added a comment. Do not enable "Custom cipher proposals" by default, that forces everyone to uncheck it. REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23713: strongswan support for custom proposals
rrichmond marked 5 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23713: strongswan support for custom proposals
rrichmond updated this revision to Diff 65711. rrichmond added a comment. Moved custom cipher proposals into its own group box, with the checked property, encompassing the IKE/ESP proposal QLineEdit boxes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23713?vs=65357=65711 REVISION DETAIL https://phabricator.kde.org/D23713 AFFECTED FILES plasma-nm-5.15.5/vpn/strongswan/nm-strongswan-service.h plasma-nm-5.15.5/vpn/strongswan/strongswanprop.ui plasma-nm-5.15.5/vpn/strongswan/strongswanwidget.cpp To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23713: strongswan support for custom proposals
jgrulich added a comment. I'm not sure the "Cipher Proposals" groupbox should be inside the "Options" groupbox, imo it should be separated groupbox INLINE COMMENTS > strongswanwidget.cpp:100 > d->ui.ipComp->setChecked(dataMap[NM_STRONGSWAN_IPCOMP] == "yes"); > +d->ui.proposal->setChecked(dataMap[NM_STRONGSWAN_PROPOSAL] == "yes"); > +d->ui.ike->setText(dataMap[NM_STRONGSWAN_IKE]); Same here, probably pointless to set "IKE" and "ESP" when "Enable custom proposals" is false. > pino wrote in strongswanwidget.cpp:155-156 > should these be set only when the custom proposals are accepted? Indeed, they should be set only when the "Enable custom proposals" checkbox is checked. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23713: strongswan support for custom proposals
rrichmond created this revision. rrichmond added reviewers: fvogt, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. rrichmond requested review of this revision. REVISION SUMMARY This patch brings feature parity with gnome's nm-connection-editor strongswan plugin. Enabling custom proposals is required in order to support connections to strict strong cipher endpoints, the default cipher list doesn't include eg: aes256gcm16-prfsha384-ecp384. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23713 AFFECTED FILES plasma-nm-5.15.5/vpn/strongswan/nm-strongswan-service.h plasma-nm-5.15.5/vpn/strongswan/strongswanprop.ui plasma-nm-5.15.5/vpn/strongswan/strongswanwidget.cpp To: rrichmond, fvogt, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
