D23782: Add "edit-none-border" icon

ngraham added a comment. I kinda liked the originally proposed icon IMO. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc: trickyricky26, ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23782: Add "edit-none-border" icon

GB_2 added a comment. In D23782#527672 , @ndavis wrote: > This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than `edit-none`. Yeah, maybe it's best if we just use that. RE

D23782: Add "edit-none-border" icon

broulik added a comment. In D23782#527560 , @GB_2 wrote: > No, then it doesn't fall back to `edit-none`. Alright, makes sense. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc

D23782: Add "edit-none-border" icon

GB_2 abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc: trickyricky26, ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23782: Add "edit-none-border" icon

ndavis added a comment. This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than `edit-none`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc: trickyricky26, ndavis,

D23782: Add "edit-none-border" icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I think it would be better if this icon had bits int he corners like many of the existing breeze icons: F7330296: Screenshot_20190908_074450.png

D23782: Add "edit-none-border" icon

GB_2 added a comment. The fallback is needed, because Plasma 5.17 depends on Frameworks 5.62, which was already tagged and `edit-none` was the best fallback I could find. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: trickyricky26, nd

D23782: Add "edit-none-border" icon

trickyricky26 added a comment. In D23782#527623 , @ndavis wrote: > What is this icon used for? @GB_2 used it here: https://phabricator.kde.org/D23779#527639. It is used for the KWin no window border context menu entry. REPOSITORY R266

D23782: Add "edit-none-border" icon

ndavis added a comment. What is this icon used for? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23782: Add "edit-none-border" icon

ngraham added a comment. On one hand I kind of agree with @kbroulik about the name choice, but on the other hand the fallback seems appropriate too. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: ngraham, broulik, kde-frameworks-devel,

D23782: Add "edit-none-border" icon

GB_2 added a comment. In D23782#527558 , @broulik wrote: > Shouldn't it be "edit-border-none"? No, then it doesn't fall back to `edit-none`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #

D23782: Add "edit-none-border" icon

broulik added a comment. Shouldn't it be "edit-border-none"? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23782: Add "edit-none-border" icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY F7329452: edit-none-border Icon.png For D23779