dfaure closed this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D23797
To: dfaure, cfeck
Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
Merci!
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23797
To: dfaure, cfeck
Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, mi
dfaure updated this revision to Diff 65703.
dfaure added a comment.
constify, sort includes
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23797?vs=65673&id=65703
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23797
AFFECTED FILES
dhaumann added a comment.
Lgtm.
INLINE COMMENTS
> dhaumann wrote in ktitlewidget.cpp:137
> Is that not needed anymore?
Sorry, the next line gives the answer ;)
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D23797
To: dfaure, cfeck
Cc: dhaumann, aacid, kde-
dhaumann added inline comments.
INLINE COMMENTS
> ktitlewidget.cpp:137
> d->headerLayout->setColumnStretch(0, 1);
> -d->headerLayout->setMargin(6);
> d->headerLayout->setContentsMargins(0, 0, 0, 0);
Is that not needed anymore?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
ht
cfeck added inline comments.
INLINE COMMENTS
> kpopupframe.cpp:24
>
> -#include
> +#include
> #include
Please keep this sorted.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D23797
To: dfaure, cfeck
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, micha
aacid added a comment.
+1 looks sane but i have **not** tried this
INLINE COMMENTS
> kcollapsiblegroupbox.cpp:288
> {
> -int top, left, right, bottom;
> -getContentsMargins(&left, &top, &right, &bottom);
> +QMargins margins = contentsMargins();
>
if you get bored, add const?
dfaure created this revision.
dfaure added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
TEST PLAN
Added "cxxflags -DQT_DISABLE_DEPRECATED_BEFORE=0x06" to
kdesrc-build's kf5-frameworks-build
