D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5
cfeck added a comment. I somehow knew autotest would fail on FreeBSD ... I cannot investigate why it fails, maybe too old MIME database? REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D23811 To: cfeck, #frameworks, aacid Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns
D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5
This revision was automatically updated to reflect the committed changes. Closed by commit R287:68bb1a0ee7f9: Port HDR (Radiance RGBE) image loader to Qt5 (authored by cfeck). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23811?vs=65784&id=66041 REVISION DETAIL https://phabricator.kde.org/D23811 AFFECTED FILES autotests/CMakeLists.txt autotests/read/hdr/rgb.hdr autotests/read/hdr/rgb.png src/imageformats/CMakeLists.txt src/imageformats/hdr.cpp src/imageformats/hdr.json src/imageformats/hdr_p.h To: cfeck, #frameworks, aacid Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns
D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. The test fails here because the autotests/read/hdr/rgb.png file is 0 bytes, but if that is a phabricator artifact and it's really not a 0 bytes size, go ahead and commit :) REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D23811 To: cfeck, #frameworks, aacid Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns
D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5
cfeck updated this revision to Diff 65784. cfeck added a comment. Add hdr to autotests REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23811?vs=65713&id=65784 REVISION DETAIL https://phabricator.kde.org/D23811 AFFECTED FILES autotests/CMakeLists.txt autotests/read/hdr/rgb.hdr autotests/read/hdr/rgb.png src/imageformats/CMakeLists.txt src/imageformats/hdr.cpp src/imageformats/hdr.json src/imageformats/hdr_p.h To: cfeck, #frameworks Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns
D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5
aacid added a comment. Could you try to figure out if adding some autotest file would be hard? i think all is needed is an autotests/read/hdr folder with some hdr files and their png counterpart and then readtest will magically pick it up REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D23811 To: cfeck, #frameworks Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns
D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5
cfeck created this revision. cfeck added a reviewer: Frameworks. cfeck added a project: Gwenview. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cfeck requested review of this revision. TEST PLAN Tested with HDR images from hdrihaven.com - Loading in KolourPaint works - Thumbnails in Dolphin work REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D23811 AFFECTED FILES src/imageformats/CMakeLists.txt src/imageformats/hdr.cpp src/imageformats/hdr.json src/imageformats/hdr_p.h To: cfeck, #frameworks Cc: kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns
