D23815: [KConfig] port away from deprecated methods in Qt 5.14

dfaure closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23815 To: dfaure, mdawson, arichardson, vkrause Cc: pino, arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23815: [KConfig] port away from deprecated methods in Qt 5.14

dfaure added a comment. I'm going to adopt a different strategy for Frameworks after all, because: - setting this in KDEFrameworksCompilerSettings.cmake would affect much more than frameworks (this stricter set of flags has been adopted by many many applications) - setting this in

D23815: [KConfig] port away from deprecated methods in Qt 5.14

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D23815 To: dfaure, mdawson, arichardson, vkrause Cc: pino, arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23815: [KConfig] port away from deprecated methods in Qt 5.14

pino added a comment. In D23815#528543 , @dfaure wrote: > If we want to enable this flag (to "punish" the first KDE developer who upgrades Qt, like me currently), then at least we should only do so in git checkouts, not in release tarballs. >

D23815: [KConfig] port away from deprecated methods in Qt 5.14

dfaure added a reviewer: vkrause. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23815 To: dfaure, mdawson, arichardson, vkrause Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23815: [KConfig] port away from deprecated methods in Qt 5.14

dfaure added a comment. Laurent: I'm talking about release tarballs. People don't fix those, that would be pointless. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23815 To: dfaure, mdawson, arichardson Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2,

D23815: [KConfig] port away from deprecated methods in Qt 5.14

mlaurent added a comment. "If a user of the last PIM release (as in, a person or a distro) wants to use Qt 5.14, they'll get compilation errors, unnecessarily." and he will fix it :) not a bad idea :) "if (EXISTS "${CMAKE_SOURCE_DIR}/.git")" I like this idea. REPOSITORY R237 KConfig

D23815: [KConfig] port away from deprecated methods in Qt 5.14

dfaure added a comment. I actually think it's a mistake to set this define unconditionally in PIM. If a user of the last PIM release (as in, a person or a distro) wants to use Qt 5.14, they'll get compilation errors, unnecessarily. If we want to enable this flag (to "punish" the

D23815: [KConfig] port away from deprecated methods in Qt 5.14

mlaurent added a comment. "This kind of thing should only be added to the developer's personal build flags, or to CI." on CI without this flags in module is just not a good idea. After that I use in pim* and it's not a problem. If a people wants to use new qt (as David :) ) he will

D23815: [KConfig] port away from deprecated methods in Qt 5.14

arojas added a comment. In D23815#528369 , @mlaurent wrote: > Why you don't add add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) in cmake toplevel ? > or 5.14 value ? so we can be sure that it builds without deprecated method until

D23815: [KConfig] port away from deprecated methods in Qt 5.14

mlaurent added a comment. Why you don't add add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) in cmake toplevel ? or 5.14 value ? so we can be sure that it builds without deprecated method until it. (I prefere QT_DISABLE_DEPRECATED_BEFORE=0x06 so we can fix it each time