D23835: Add TabKCM

2020-12-06 Thread Nicolas Fella 
nicolasfella abandoned this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: broulik, onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D23835: Add TabKCM

2019-10-10 Thread Kai Uwe Broulik 
broulik added a comment.


  Don't use ECMAScript 6 stuff in KDeclarative or plasma-framework! It is a 
Framework which has a minimum version version support of Qt 5.11 (last three, 
5.13, 5.12, 5.11). ECMAScript 6 is only in Qt 5.12

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: broulik, onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23835: Add TabKCM

2019-10-09 Thread Nathaniel Graham 
ngraham added a dependent revision: D24224: Start of the accessibility KCM.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23835: Add TabKCM

2019-09-26 Thread Marco Martin 
mart added a comment.


  as background it should probably use a Frame component (which atm in the 
style is just a simple Rectangle.. si i should fix that and make it draw the 
proper raised frame;)
  
  also, sadly, it will have to look good-ish also with other styles, like omg, 
oxygen

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23835: Add TabKCM

2019-09-10 Thread Nathaniel Graham 
ngraham added a comment.


  In D23835#528756 , @onvitaik wrote:
  
  > Can I also suggest making the tabs occupy the full width of the area 
available (sort of like Kate)? It minimizes the unused space and keeps 
everything in a nice rectangle:
  >
  > F7337756: wide_tabs.png 
  
  
  I kind of like it myself, but if we do this, we'd want to also make the same 
change for our QWidgets tabs for consistency. Might be better to do that later 
in subsequent patches.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23835: Add TabKCM

2019-09-10 Thread Onvitai Kayan 
onvitaik added a comment.


  Can I also suggest making the tabs occupy the full width of the area 
available? It minimizes the unused space and keeps everything in a nice 
rectangle:
  
  F7337756: wide_tabs.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23835: Add TabKCM

2019-09-10 Thread Nicolas Fella 
nicolasfella edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

2019-09-10 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 65761.
nicolasfella added a comment.


  - Implement Vlad's suggestion

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23835?vs=65760&id=65761

BRANCH
  tabkcm

REVISION DETAIL
  https://phabricator.kde.org/D23835

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/Tab.qml
  src/qmlcontrols/kcmcontrols/qml/TabKCM.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

2019-09-10 Thread Nicolas Fella 
nicolasfella added a comment.


  In D23835#528688 , @ngraham wrote:
  
  > Nice, I think we need this.
  >
  > From the image, I think the frame's background color needs to be the same 
as the active tab color, and there shouldn't be a line separating them, This is 
something we currently have in the Plasma-pa KCM (albeit with the wrong 
background color), but we lose it with this new KCM style.
  
  
  Achieving this was easier than I initially thought, but now the color of the 
active tab doesn't match the content. With the line in this was much less of a 
problem

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

2019-09-10 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 65760.
nicolasfella added a comment.


  - Remove line beneath active tab

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23835?vs=65755&id=65760

BRANCH
  tabkcm

REVISION DETAIL
  https://phabricator.kde.org/D23835

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/Tab.qml
  src/qmlcontrols/kcmcontrols/qml/TabKCM.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

2019-09-10 Thread Nathaniel Graham 
ngraham added a comment.


  Also related: the lack of a real QML tab view: 
https://bugs.kde.org/show_bug.cgi?id=394296

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

2019-09-10 Thread Nathaniel Graham 
ngraham added a dependent revision: D23836: Use new TabKCM API.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

2019-09-10 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> TabKCM.qml:153-160
> +var theTabs = []
> +var i = 0
> +
> +for( i=0; i < tabs.length; i++) {
> +tabs[i].delegate.createObject(sl, {})
> +theTabs.push(tabs[i].title)
> +}

FYI, QML has some features from ECMAScript 6, so you could make this code a bit 
cleaner, e.g.

  for (const tab of tabs)
  tab.delegate.createObject(sl, {});
  
  tabsRepeater.model = tabs.map(tab => tab.title);

(I didn't test whether this code actually works)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

2019-09-10 Thread Nathaniel Graham 
ngraham added a comment.


  Nice, I think we need this.
  
  From the image, I think the frame's background color needs to be the same as 
the active tab color, and there shouldn't be a line separating them, This is 
something we currently have in the Plasma-pa KCM (albeit with the wrong 
background color), but we lose it with this new KCM style.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

2019-09-10 Thread Nicolas Fella 
nicolasfella edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23835: Add TabKCM

2019-09-10 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  We have quite a few KCMs that use tabs as top-level components. Since tabs 
are a bit weird in QML quite a few workarounds have been piling up in some 
KCMs, making them inconsistent with each other.
  
  By adding a common TabKCM API we can unify the presentation and implementation

REPOSITORY
  R296 KDeclarative

BRANCH
  tabkcm

REVISION DETAIL
  https://phabricator.kde.org/D23835

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/Tab.qml
  src/qmlcontrols/kcmcontrols/qml/TabKCM.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir

To: nicolasfella, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns