D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

2019-09-14 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23898

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

2019-09-12 Thread Elvis Angelaccio 
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  Everything looks good and the new test passes for me.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

2019-09-12 Thread David Faure 
dfaure added a comment.


  In D23898#529947 , 
@elvisangelaccio wrote:
  
  > I don't have 5.14 around atm, so I trust you've tested this :)
  
  
  Well the only new thing in 5.14 is a runtime warning. This patch should work 
with older versions of Qt too :-)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

2019-09-12 Thread David Faure 
dfaure updated this revision to Diff 65905.
dfaure added a comment.


  Clean up autotest code

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23898?vs=65903=65905

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

AFFECTED FILES
  autotests/kurlnavigatortest.cpp
  autotests/kurlnavigatortest.h
  src/filewidgets/kurlnavigatorbutton.cpp
  src/filewidgets/kurlnavigatorbutton_p.h

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

2019-09-12 Thread Elvis Angelaccio 
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  I don't have 5.14 around atm, so I trust you've tested this :)

INLINE COMMENTS

> kurlnavigatortest.cpp:265
> +KFilePlacesModel model;
> +const QString pwd = QDir::currentPath();
> +const QUrl url = QUrl::fromLocalFile(pwd);

Did you mean `cwd` ?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

2019-09-12 Thread David Faure 
dfaure created this revision.
dfaure added a reviewer: elvisangelaccio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Since Qt-5.14 this leads to a runtime warning from QCharRef.
  
  The solution resizes "big" before hand, and then resizes again at
  the end, to the final size.

TEST PLAN
  running dolphin; new unittest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

AFFECTED FILES
  autotests/kurlnavigatortest.cpp
  autotests/kurlnavigatortest.h
  src/filewidgets/kurlnavigatorbutton.cpp
  src/filewidgets/kurlnavigatorbutton_p.h

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns