nicolasfella added a comment.
This fixed it for me, thanks
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23944
To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure added a comment.
It built for me; but I pushed a missing include.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23944
To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
broulik added a comment.
This breaks the build:
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/219/
/home/jenkins/workspace/Frameworks/kio/kf5-qt5
SUSEQt5.12/src/widgets/krun_p.h:97:10: error: ���unique_ptr��� in namespace
���std��� does not name a template typ
dfaure closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23944
To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
1_kprocesrunner
REVISION DETAIL
https://phabricator.kde.org/D23944
To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure created this revision.
dfaure added reviewers: vkrause, nicolasfella, broulik.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.
REVISION SUMMARY
- Make that functionality QWidget-inde