D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

2019-09-18 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R296:f50f67127259: Delete QQmlObjectSharedEngine context in sync with QQmlObject (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24023?

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

2019-09-17 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This fixes the crash for me. Thanks! REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D24023 To: davidedmundson, #plasma, dfaure Cc: kde-framew

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

2019-09-17 Thread David Edmundson
davidedmundson edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24023 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

2019-09-17 Thread Kai Uwe Broulik
broulik added a reviewer: dfaure. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24023 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

2019-09-17 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise we leave a context dangling with no engine, which is we