D24046: Allow triggering sort from QML

This revision was automatically updated to reflect the committed changes. Closed by commit R307:1e339edef781: Allow triggering sort from QML (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24046?vs=70833&id=70838 REVISION DETAIL h

D24046: Allow triggering sort from QML

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH fo REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: mpyne, jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24046: Allow triggering sort from QML

nicolasfella updated this revision to Diff 70833. nicolasfella added a comment. Override and forward REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24046?vs=66370&id=70833 BRANCH fo REVISION DETAIL https://phabricator.kde.org/D24046 AFFECTED FILES

D24046: Allow triggering sort from QML

mpyne added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > "You can ... reimplement virtual functions defined in the primary base class > hierarchy (that is, virtuals defined in the first non-virtual base class, or > in that class's first non-virtual base

D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > ... which people say is ABI-compatible "You can ... reimplement virtual functions defined in the primary base class hierarchy (that is, virtuals defined in the first non-virtual base class, or i

D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > Can you just forward the entire thing: > > Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) > override; ... which people say is ABI-compatible REPOSITORY R307 KP

D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > personssortfilterproxymodel.h:53 > bool filterAcceptsRow(int source_row, const QModelIndex &source_parent) > const override; > +Q_INVOKABLE void sortNow(); > Can you just forward the entire thing: Q_INVOKABLE void sort(int column, Q

D24046: Allow triggering sort from QML

jbbgameich added a comment. Can we get one of the two ways accepted so we can progress on the phonebook merge request? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michae

D24046: Allow triggering sort from QML

nicolasfella added a comment. In D24046#542147 , @jbbgameich wrote: > why not > > Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) override { > QSortFilterProxyModel::sort(column, order); > } >

D24046: Allow triggering sort from QML

jbbgameich added a comment. why not Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) override { QSortFilterProxyModel::sort(column, order); } instead of adding a new function? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.k

D24046: Allow triggering sort from QML

broulik added a comment. Meh, I could have sworn `sort` was `Q_INVOKABLE` :( REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24046: Allow triggering sort from QML

nicolasfella edited the summary of this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24046: Allow triggering sort from QML

nicolasfella updated this revision to Diff 66370. nicolasfella added a comment. - Whitespace-- REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24046?vs=66369&id=66370 BRANCH sort REVISION DETAIL https://phabricator.kde.org/D24046 AFFECTED FILES src/

D24046: Allow triggering sort from QML

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY I was missing a way to trigger the sorting of my contacts list from QML