D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:22132a50c4a8: Deprecate the global 
[Small|Desktop|Bar]Icon() methods (authored by vkrause).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24136?vs=66606=66617

REVISION DETAIL
  https://phabricator.kde.org/D24136

AFFECTED FILES
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[Volker Krause]

vkrause updated this revision to Diff 66606.
vkrause added a comment.


  Actually use KICONTHEMES_NO_DEPRECATED correctly.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24136?vs=66605=66606

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24136

AFFECTED FILES
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[Volker Krause]

vkrause updated this revision to Diff 66605.
vkrause added a comment.


  Use KICONTHEMES_NO_DEPRECATED.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24136?vs=66592=66605

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24136

AFFECTED FILES
  src/kiconloader.h

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[Volker Krause]

vkrause added a task: T11654: Deprecate 
SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of 
KIconLoader or QIcon API.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[Volker Krause]

vkrause added a comment.


  In D24136#535818 , @dfaure wrote:
  
  > kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
  >  (and that's all I can find in all of KF5)
  
  
  Right, usage is fortunately not very wide-spread anymore. Before porting the 
remaining users I just wanted to be sure there are no objections to the general 
idea.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  LOL I had no idea that one could do SmallIcon("foo", KIconLoader::SizeLarge) 
;-)
  
  I think 95% of the uses of these functions only specifies one argument.
  
  Then again, I just grepped for usage of SmallIcons in KF5, and one of the 
only two hits in non-deprecated modules is
  
kio/src/filewidgets/kimagefilepreview.cpp
200:
imageLabel->setPixmap(SmallIcon(QStringLiteral("image-missing"), 
KIconLoader::SizeLarge,
  
  Can you port KIO?
  
  Also I think you're missing #ifndef KICONTHEMES_NO_DEPRECATED around the 
newly deprecated methods
  (which helps to do a local experimental build with this being set, to catch 
all users and port them).

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[David Faure]

dfaure added a comment.


  kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
  (and that's all I can find in all of KF5)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  They are not namespaced and promote the use of pixmaps rather than
  icons. Additionally their API allowing to specify a size that differs
  from the size suggested by their name leads to bizarre usage like
  'SmallIcon("foo", KIconLoader::SizeLarge)'.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24136

AFFECTED FILES
  src/kiconloader.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns