D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure added a comment. In D24171#539612 , @ahmadsamir wrote: > (Reminder: I don't have a dev account so you'll have to commit the patches :)). If you keep this up, you should ask for one :-) REPOSITORY R241 KIO BRANCH ahmad/foreac

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir added a comment. (Reminder: I don't have a dev account so you'll have to commit the patches :)). REPOSITORY R241 KIO BRANCH ahmad/foreach-filewidgets (branched from master) REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure Cc:

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH ahmad/foreach-filewidgets (branched from master) REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure C

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir updated this revision to Diff 67008. ahmadsamir added a comment. Don't iterate over the temp. container returned by qhash.keys(), rather over the qhash itself REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24171?vs=67007&id=67008 BRANCH ahmad/for

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure added inline comments. INLINE COMMENTS > kfilepreviewgenerator.cpp:733 > // to use their default MIME type icon. > -foreach (const QUrl &url, m_cutItemsCache.keys()) { > -const QModelIndex index = dirModel->indexForUrl(url); > +auto it = m_cutItemsCache.keys().cbegin()

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir updated this revision to Diff 67007. ahmadsamir added a comment. Change according to comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24171?vs=66899&id=67007 BRANCH ahmad/foreach-filewidgets (branched from master) REVISION DETAIL https:/

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kurlnavigator.cpp:803 > I thought button->deleteLater() may change m_navButtons, doesn't it? How would it? It doesn't know that container. All it does is posting an event to that object. The container isn't modified. [and even

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir marked 2 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kurlnavigator.cpp:803 > Why not a range for here? It should be just fine. I thought button->deleteLater() may change m_navButtons, doesn't it? REPOSITORY R241 KIO REVISION DETAIL

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfilepreviewgenerator.cpp:733 > // to use their default MIME type icon. > -foreach (const QUrl &url, m_cutItemsCache.keys()) { > +const QList list

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir updated this revision to Diff 66899. ahmadsamir added a comment. More implicit sharing detach prevention REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24171?vs=66698&id=66899 BRANCH ahmad/foreach-filewidgets (branched from master) REVISION DETAI

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir added a comment. In D24171#536712 , @dfaure wrote: > Cool, I'll review this. BTW don't touch begin/end loops, that's done in D24160 already. Yep, I saw it on the ML :-) REPOSITORY R241 KI

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure added a comment. Cool, I'll review this. BTW don't touch begin/end loops, that's done in D24160 already. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure Cc: kde-frameworks-dev

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir created this revision. ahmadsamir added reviewers: kde-frameworks-devel, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code compiles and tests pass REPOSITORY R241 KIO BRANCH ahmad/foreach-filewidgets (branched from maste