D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e0ef6b7ed41a: Make 22px squiggle more like 16px squiggle 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24253?vs=66931=67148

REVISION DETAIL
  https://phabricator.kde.org/D24253

AFFECTED FILES
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: ndavis, #vdg
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

ndavis added a comment.


  In D24253#538662 , @trickyricky26 
wrote:
  
  > Visually I think this is fine and a good improvement.
  >
  > I wonder why your SVGs have two seperate paths as opposed to unifying them 
into one path (as I usually do)? Just curious if there is any benefit to using 
one approach above the other.
  >  Also, judging by the MDN Page 
 I don't 
think the `fill-rule="evenodd"` does anything here.
  
  
  Sometimes the optimizers prefer to group rather than combine. These days, 
optimization is used to keep diffs readable so I can find mistakes and to cut 
down the size most of the way. Optimizing down to the last byte we can get rid 
of is not necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24253: Make 22px squiggle more like 16px squiggle

[TrickyRicky]

trickyricky26 added a comment.


  Visually I think this is fine and a good improvement.
  
  I wonder why your SVGs have two seperate paths as opposed to unifying them 
into one path (as I usually do)? Just curious if there is any benefit to using 
one approach above the other.
  Also, judging by the MDN Page 
 I don't 
think the `fill-rule="evenodd"` does anything here.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  squiggle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24253

AFFECTED FILES
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns