D24318: Make 32px document-save icon colorful

2019-10-27 Thread Nathaniel Graham 
ngraham abandoned this revision.
ngraham added a comment.


  Abandoned in favor of D24975 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

2019-10-12 Thread Björn Feber 
GB_2 added a comment.


  In D24318#542048 , @ndavis wrote:
  
  > Yeah, that was a feature of the original icon that I didn't remove. I 
wasn't so sure about it either.
  
  
  If you don't like it then remove it :P

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis 
ndavis added a comment.


  In D24318#541952 , @churaev wrote:
  
  > In D24318#541839 , @ndavis wrote:
  >
  > > How about this?
  > >  F7513643: document-save.svg 
  > >  F7513644: montage.png 
  >
  >
  > Should the metal tab on the top cast a shadow this long? It looks strange 
to me.
  >
  > The tab is normally perfectly flush with the non-indented region of the 
cover (picture 
).
  
  
  Yeah, that was a feature of the original icon that I didn't remove. I wasn't 
so sure about it either.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis 
ndavis added a comment.


  In D24318#542043 , @ngraham wrote:
  
  > @ndavis You wanna just submit a patch with that and I'll abandon this?
  
  
  Alright

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Nathaniel Graham 
ngraham added a comment.


  @ndavis You wanna just submit a patch with that and I'll abandon this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Nathaniel Graham 
ngraham added a comment.


  Heh that's a ton better than mine. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Nikita Churaev 
churaev added a comment.


  In D24318#541839 , @ndavis wrote:
  
  > How about this?
  >  F7513643: document-save.svg 
  >  F7513644: montage.png 
  
  
  Should the metal tab on the top cast a shadow this long? It looks strange to 
me.
  
  The tab is normally perfectly flush with the non-indented region of the cover 
(picture 
).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Björn Feber 
GB_2 added a comment.


  In D24318#541839 , @ndavis wrote:
  
  > How about this?
  >  F7513643: document-save.svg 
  >  F7513644: montage.png 
  
  
  I love it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis 
ndavis added a comment.


  How about this?
  F7513643: document-save.svg 
  F7513644: montage.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-10-03 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-10-03 Thread Nathaniel Graham 
ngraham updated this revision to Diff 67298.
ngraham added a comment.


  Use a nicer color for the label

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24318?vs=67263=67298

BRANCH
  colorful-32px-save-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24318

AFFECTED FILES
  icons-dark/actions/32/document-save.svg
  icons/actions/32/document-save.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-10-03 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-10-03 Thread Nathaniel Graham 
ngraham updated this revision to Diff 67263.
ngraham added a comment.


  Update according to review comments

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24318?vs=67083=67263

BRANCH
  colorful-32px-save-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24318

AFFECTED FILES
  icons-dark/actions/32/document-save.svg
  icons/actions/32/document-save.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-09-30 Thread Noah Davis 
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  - I think this doesn't look enough like the monochrome versions and it looks 
too much like the KFloppy icon.
- Make the label area more similar to the monochrome icons.
- Maybe choose a darker set of grays. These are based on the current Breeze 
colors. You might already know, but avoid going too close to `#fcfcfc`, 
`#eff0f1`, `#31363b` and `#232629`.
  - F7476982: drawing.svg 
  - Margins need to be 2px, not 4px. 4px was for monochrome 32px.
  - The corners of the hole in the metal slide don't quite reach the nearest 
grid snapping points.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-09-30 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

2019-09-30 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We're trying to move away from using the monochrome style for >22px action 
icons. This
  patch replaces the 32px monochrome `document-save` icon with a colorful 
version.
  
  BUG: 412404
  FIXED-IN: 5.63

TEST PLAN
  This icon used in various apps' settings windows now looks good:
  Spectacle: F7475818: In spectacle.png 
  KWrite: F7475819: In KWrite.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  colorful-32px-save-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24318

AFFECTED FILES
  icons-dark/actions/32/document-save.svg
  icons/actions/32/document-save.svg

To: ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns