D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-03 Thread Nibaldo González
nibags updated this revision to Diff 67297. nibags added a comment. Minor corrections: - Restore WordDetect rules - Use **kateversion="5.44"** (WordDetect with insensitive). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24354?vs=67161&id

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Nibaldo González
nibags added a comment. i did it in: D24378 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Dominik Haumann
dhaumann added a comment. Thanks a lot! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demski

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Nibaldo González
nibags added a comment. I think it makes sense to change this in WorDetect: verify delimiter characters on the left and right edge of the string, either inside or outside the string. I will make another diff with this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabrica

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Dominik Haumann
dhaumann added a comment. Hm, would it make sense to change this? I.e. if the word itself has a word boundary, also use this? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Nibaldo González
nibags added a comment. Indeed, WordDetect checks only the boundaries. What happens is that when using WordDetect with `". It's correct to use RegExpr with `https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-dev

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Dominik Haumann
dhaumann added a comment. Would it also be an option to fix WordDetect? I always thought WordDetect ignores the string contents, it should only check on the boundaries left and right REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #fra

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-01 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Using `WordDetect` rules for