D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-05 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R309:9f4b516eac6b: Move Amusement to Games directory instead 
of Games > Toys (authored by Guo Yunhe ).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67310&id=67343

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo 
guoyunhe added a comment.


  If I install amor, it would be shown in both Games and Games > Toys. This 
patch will let it only shows in Games.
  
  Another situation is that, if the application is 
`Categories=Multimedia;Amusement;`, it will not fit Games or Games>Toys. This 
patch can also help to always follow the primary category. (Amusement is an 
additional/secondary category)

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 67310.
guoyunhe added a comment.


  In case Amusement is under other primary category, let it be placed in its 
actually primary category, rather than force it in Games.

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67304&id=67310

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo 
guoyunhe added a comment.


  In RPM package groups, **Amusement** is a top level category and **Game** is 
its child category. So a game can be categorized as **Amusement/Game/Other**.
  
  However, in freedesktop.org specification, **Game** is primary category. 
**Amusement** is secondary category but not under **Game**.
  
  I searched through all KDE apps to find **Amusement** category in desktop 
files. And find the only one :
  
  amor - Amusing Misuse of Resources animation that sits on top of the curent 
window. Categories=Qt;KDE;Game;Amusement;
  
  F7514185: image.png 

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo 
guoyunhe edited the summary of this revision.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 67304.
guoyunhe added a comment.


  Update description

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67252&id=67304

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Luigi Toscano 
ltoscano added a comment.


  Can you please at least remove the steam example from the commit message, as 
it is not relevant (it is a downstream change) and remove the reference to the 
bug?
  Does it also mean that kf5-toys.directory is not used anymore? (not sure 
whether it can't be removed anyway for compatibility?)

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Albert Astals Cid 
aacid added a comment.


  I don't appreciate the flippant and dismissive attitude in that comment. I 
would ask that you interact with more respectfulness. Thanks.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D24384#541646 , @aacid wrote:
  
  > Really? toys are only for children and adults should be ashamed to play 
with toys? Come on, i thought we were past that.
  
  
  Maybe it's different in your native language and country. But in English, and 
in the USA, there's a clear stigma to describing something not designed to be a 
children's plaything as a toy.
  
  I don't appreciate the flippant and dismissive attitude in that comment. I 
would ask that you interact with more respectfulness. Thanks.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Albert Astals Cid 
aacid added a comment.


  Lol it's opensuse being silly, oh well.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Albert Astals Cid 
aacid added a comment.


  Really? toys are only for children and adults should be ashamed to play with 
toys? Come on, i thought we were past that.
  
  Anyway, i'm really confused now, does your Stream have the Amusement category?
  
  Because the steam.desktop from 
http://repo.steampowered.com/steam/pool/steam/s/steam/steam_1.0.0.61.tar.gz says
  
Categories=Network;FileTransfer;Game;
  
  Which Steam version are you running?
  
  No, i don't know of any app that we have (or otherwise) that uses the 
Amusement category

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Nathaniel Graham 
ngraham added a reviewer: VDG.
ngraham added a comment.


  I agree with @guoyunhe. "Toys" isn't an appropriate word to use in the 
context of computers and software. From a native English speaker's perspective 
here, a toy is something physical that you give to children. Using the word to 
describe something anything else is actually insulting to that thing ("don't 
use that app, it's a toy compared to this other one") and by extension, the 
people who created it.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Yunhe Guo 
guoyunhe added a comment.


  In D24384#541589 , @aacid wrote:
  
  > Have you contacted Valve to tell them amusement is the wrong category for 
Steam?
  >
  > Because the spec says Amusement - > a simple amusement
  >
  > And that's not what steam is
  >
  > IMHO this patch is wrong and steam is what needs fixing.
  
  
  Dispite what Steam belongs to, "a simple amusement" should not be named 
"toys". Do we have any applications or games that are "toys"?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Albert Astals Cid 
aacid added a comment.


  Have you contacted Valve to tell them amusement is the wrong category for 
Steam?
  
  Because the spec says Amusement - > a simple amusement
  
  And that's not what steam is
  
  IMHO this patch is wrong and steam is what needs fixing.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Nathaniel Graham 
ngraham added a comment.


  +1

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 67252.
guoyunhe added a comment.


  Fix tabs

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67251&id=67252

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Yunhe Guo 
guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  The Amusement category doesn't mean it is about toys. For example, Steam, the 
gaming platform and store, isn't about toys.
  
  BUG 412553

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns