D24389: Fix klistopenfilesjob header file not being installed

2019-10-05 Thread David Hallas 
hallas added a comment.


  In D24389#541644 , @dfaure wrote:
  
  > `git tag` doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so 
this commit will be included.
  >
  > (I do that on the first Saturday of the month)
  
  
  Phew :) Glad that this one made it

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24389: Fix klistopenfilesjob header file not being installed

2019-10-03 Thread David Faure 
dfaure added a comment.


  `git tag` doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so 
this commit will be included.
  
  (I do that on the first Saturday of the month)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24389: Fix klistopenfilesjob header file not being installed

2019-10-03 Thread David Hallas 
hallas added a comment.


  In D24389#541539 , @ngraham wrote:
  
  > Please land this ASAP so it gets into Frameworks 5.63.
  
  
  Landed it now, is there anything else I need to do so that it makes the 5.63 
release?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24389: Fix klistopenfilesjob header file not being installed

2019-10-03 Thread David Hallas 
hallas closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24389: Fix klistopenfilesjob header file not being installed

2019-10-03 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Please land this ASAP so it gets into Frameworks 5.63.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24389: Fix klistopenfilesjob header file not being installed

2019-10-03 Thread Méven Car 
meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24389: Fix klistopenfilesjob header file not being installed

2019-10-03 Thread David Hallas 
hallas created this revision.
hallas added reviewers: dfaure, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  The header file KListOpenFilesJob and klistopenfilesjob.h was not being
  installed

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24389

AFFECTED FILES
  src/lib/CMakeLists.txt

To: hallas, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns