aacid abandoned this revision.
aacid added a comment.
Meh, just realized this patch is useless since we end up passing the quint
variable to formatSingleDuration that passes it to QObject::tr and that one
only supports int, so at some point there's a potential loss of range anyway
REPOSITORY
aacid added inline comments.
INLINE COMMENTS
> aacid wrote in kformatprivate.cpp:339
> because its unnecessary, qint64 / number don't need a quint64 to store it.
sorry i just realized ms is quint64, so yes sshould b quint64
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kd
aacid planned changes to this revision.
aacid added inline comments.
INLINE COMMENTS
> usta wrote in kformatprivate.cpp:339
> why dont we use quint64 in here ?
because its unnecessary, qint64 / number don't need a quint64 to store it.
> usta wrote in kformatprivate.cpp:470
> same problem here
usta added inline comments.
INLINE COMMENTS
> kformatprivate.cpp:339
>
> -int hours = ms / MSecsInHour;
> +const qint64 hours = ms / MSecsInHour;
> ms = ms % MSecsInHour;
why dont we use quint64 in here ?
> kformatprivate.cpp:470
> quint64 ms = msecs;
> int days = ms /
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
msec is qint64 and pretty sure the biggest qint64 / 360 still doesn't fit
in an integer
REPOSITORY
R244 KCoreAddons
