D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-08 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:50593c561899: Add standard icons to support to all 
entries in QDialogButtonBox (authored by GB_2).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24415?vs=67336=67508

REVISION DETAIL
  https://phabricator.kde.org/D24415

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: GB_2, #frameworks, #vdg, davidedmundson, ngraham
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-05 Thread David Edmundson 
davidedmundson accepted this revision.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson, ngraham
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-05 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson, ngraham
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-05 Thread Björn Feber 
GB_2 updated this revision to Diff 67336.
GB_2 marked 2 inline comments as done.
GB_2 added a comment.


  Address comments

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24415?vs=67329=67336

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Noah Davis 
ndavis added inline comments.

INLINE COMMENTS

> kstyle.cpp:428
> +case QStyle::SP_DialogSaveAllButton:
> +return QIcon::fromTheme(QStringLiteral("document-save"));
> +case QStyle::SP_DialogAbortButton:

why not `document-save-all`?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Dominik Haumann 
dhaumann added inline comments.

INLINE COMMENTS

> kstyle.cpp:422
>  }
> +#if QT_VERSION >= 0x050E00 // Check if Qt version >= 5.14
> +case QStyle::SP_DialogYesToAllButton:

Instead of 0x050E00 you could use the macro QT_VERSION_CHECK(5, 14, 0). This 
would be a bit more self explanatory.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 398973
  Implement the new enumarations introduced in Qt 5.14: 
https://codereview.qt-project.org/c/qt/qtbase/+/254494/

TEST PLAN
  Can't really test since Qt 5.14 is not released yet, but QDialogButtonBox 
buttons should now all have icons.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: GB_2, #frameworks, #vdg
Cc: #vdg, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Björn Feber 
GB_2 added a reviewer: davidedmundson.
GB_2 added a subscriber: davidedmundson.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, #vdg, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, 
michaelh, ngraham, bruns