D24434: Fix include path to kjob.h

[David Hallas]

hallas added a comment.


  In D24434#542440 , @dfaure wrote:
  
  > Argh, I retagged, but this wasn't pushed yet.
  >  Landing and retagging again...
  
  
  Thanks a lot and sorry for the screwups :D

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24434

To: hallas, dfaure, meven, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24434: Fix include path to kjob.h

[David Faure]

dfaure closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24434

To: hallas, dfaure, meven, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24434: Fix include path to kjob.h

[David Faure]

dfaure added a comment.


  Argh, I retagged, but this wasn't pushed yet.
  Landing and retagging again...

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24434

To: hallas, dfaure, meven, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24434: Fix include path to kjob.h

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24434

To: hallas, dfaure, meven, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24434: Fix include path to kjob.h

[David Hallas]

hallas added a comment.


  @dfaure  - I just found that if you include `KListOpenFilesJob` from e.g. 
Dolphin then it fails because it cannot include `jobs/kjob.h` :(
  
  It would be really nice to have this commit in the coming Frameworks release, 
do you think that is possible?
  
  Sorry for all these late fixes :/

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24434

To: hallas, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24434: Fix include path to kjob.h

[David Hallas]

hallas created this revision.
hallas added reviewers: dfaure, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fix include path to kjob.h. When kcoreaddons is installed all the
  headers files are installed in the same directory, so we shouldn't use
  jobs/ when including files from public header files.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24434

AFFECTED FILES
  src/lib/util/klistopenfilesjob.h

To: hallas, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns