D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

This revision was automatically updated to reflect the committed changes. Closed by commit R276:974a3ad18c05: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer (authored by davidre). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

GB_2 added a dependent revision: D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

staniek removed a reviewer: KEXI. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #kde_edu, #kde_pim, #kpublictransport, #amarok, ngraham, #kexi Cc: ndavis,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ndavis added a comment. In D24453#543063 , @ngraham wrote: > Nice. Is there any way to make it touch the edges of its parent view rather than having those small margins? I would like this. I'm not aware of any place where we use margins

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ndavis added a comment. Why do the gray rectangles have margins around them? I don't like the look very much. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh I see. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a comment. In D24453#544251 , @ngraham wrote: > +1. Can you do the same thing for the similar header that's seen in System Settings' icon view? > > F7556761: Screenshot_20191009_085522.png

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. +1. Can you do the same thing for the similar header that's seen in System Settings' icon view? F7556761: Screenshot_20191009_085522.png REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre marked an inline comment as done. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, #kpublictransport, #amarok Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre updated this revision to Diff 67529. davidre added a comment. Make code more expressive and add comments REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24453?vs=67480=67529 BRANCH newcategorystyle (branched from master) REVISION DETAIL

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ognarb added inline comments. INLINE COMMENTS > kcategorydrawer.cpp:88 > +textRect.setTop(textRect.top() + 4); > +textRect.setLeft(textRect.left() + 8); > textRect.setHeight(fontMetrics.height()); Instead of using magic number, I would create a constant named padding.

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. LGTM except for the abrupt end on the right side where the scrollbar's area begins, but this is a pre-existing problem with all things that butt up against a scrollbar in a scrollview, and I think we should add a vertical separator line to fix it universally.

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a reviewer: Amarok. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, #kpublictransport, #amarok Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added reviewers: Konversation, KEXI, KDE Edu, KDE PIM, KPublicTransport. davidre added a comment. Looking at lxr other users include (not exhaustive, I may have missed some) Konversation F7546131: Screenshot_20191008_105439.png Kexi (don't

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre edited the test plan for this revision. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre updated this revision to Diff 67480. davidre edited the summary of this revision. davidre added a comment. Set categoryspacing to 0 REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24453?vs=67408=67480 BRANCH newcategorystyle (branched from

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. In D24453#543069 , @davidre wrote: > I could set `categorySpacing` in `KCategorizedView::Private::Private` to 0. F7538956: Screenshot_20191007_163458.png > But the difference is

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a comment. I could set `categorySpacing` in `KCategorizedView::Private::Private` to 0. F7538956: Screenshot_20191007_163458.png But the difference is that in widgets the scrollbar doesn't overlap the contents. REPOSITORY R276

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. Might also be nice to add a comment somewhere in here reminding people to adjust the Kirigami BasicListHeader accordingly when this is changed (and vice versa). REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a task: T10384: Unify styles for lists and their buttons. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. Nice. Is there any way to make it touch the edges of its parent view rather than having those small margins? REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre edited the summary of this revision. davidre edited the test plan for this revision. davidre added reviewers: Frameworks, VDG. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453