D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:56 > This breaks builds with CMake 3.5 - 3.7, as `$` was only added for CMake > 3.8. > > See what the official minimum required CMake version 3.5 allows here: > https://cmake.org/cmake/help/v3.5/manual/cmake-gene

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:56 > +COMMAND ${CMAKE_COMMAND} -E env > + > $,PATH,LD_LIBRARY_PATH>=$ > +$ -i ${CMAKE_CURRENT_BINARY_DIR}/tmp.qrc > -o ${RESOURCE_FILE} This breaks builds with CMake 3.5 - 3.7, as `$` was only added

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ltoscano added a comment. In D24477#547779 , @ndavis wrote: > For some reason, Arc made me the committer and the author instead of just the committer. Maybe because patches sent through the phabricator web interface have no authorship in

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ndavis added a comment. For some reason, Arc made me the committer and the author instead of just the committer. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, b

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ndavis added a comment. Thanks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7fea43c57c59: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24477?vs=67456&id=67586 REV

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ndavis retitled this revision from "[PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation" to "Add PATH/LD_LIBRARY_PATH to qrcAlias invocation". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast0