D24539: [Database] Rework handling environment flags

2019-10-11 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:198f82eb511f: [Database] Rework handling environment 
flags (authored by hurikhan77, committed by ngraham).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24539?vs=67680=67723

REVISION DETAIL
  https://phabricator.kde.org/D24539

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  fixes/prepare-readahead

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Kai Krakow 
hurikhan77 updated this revision to Diff 67680.
hurikhan77 added a comment.


  Using single-patch-per-branch approach
  
  This feels unnatural... :-\

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24539?vs=67677=67680

BRANCH
  fixes/prepare-readahead

REVISION DETAIL
  https://phabricator.kde.org/D24539

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Kai Krakow 
hurikhan77 added a comment.


  Now arc squashed all my commits into one single diff... I'm not sure if I 
like that.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Kai Krakow 
hurikhan77 updated this revision to Diff 67677.
hurikhan77 added a comment.


  Rebase and submit with arc
  
  - [Database] Rework handling environment flags
  - [Database] Disable read-ahead to prevent thrashing

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24539?vs=67628=67677

BRANCH
  fixes/readahead

REVISION DETAIL
  https://phabricator.kde.org/D24539

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Kai Krakow 
hurikhan77 added a comment.


  In D24539#545019 , @ngraham wrote:
  
  > This doesn't apply cleanly on master. Can you rebase it?
  
  
  This is strange because I rebased it to latest master just before submitting 
it here. Maybe I used an outdated mirror. Let me check.
  
  > Also it would be nice to use `arc` to submit patches: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist
  
  Ah, there it is. It isn't in the default Gentoo repository.
  
  Will check back soon.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

2019-10-10 Thread Nathaniel Graham 
ngraham added a comment.


  This doesn't apply cleanly on master. Can you rebase it?
  
  Also it would be nice to use `arc` to submit patches: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

2019-10-10 Thread Kai Krakow 
hurikhan77 added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

2019-10-10 Thread Kai Krakow 
hurikhan77 added a dependent revision: D24540: [Database] Disable read-ahead to 
reduce thrashing.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24539: [Database] Rework handling environment flags

2019-10-10 Thread Kai Krakow 
hurikhan77 created this revision.
hurikhan77 added a reviewer: ngraham.
hurikhan77 added a project: Baloo.
Herald added a project: Frameworks.
Herald added subscribers: Baloo, kde-frameworks-devel.
hurikhan77 requested review of this revision.

REVISION SUMMARY
  This will keep the code of the following changes simpler to read. It 
introduces no functional change.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams