D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:f436762fb366: Dont build static library when 
BUILD_TESTING=OFF (authored by arojas).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24554?vs=67674=67705

REVISION DETAIL
  https://phabricator.kde.org/D24554

AFFECTED FILES
  src/solid/CMakeLists.txt

To: arojas, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D24554

To: arojas, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Since the static library is only used for autotests, don't waste CPU cycles 
when not building them

TEST PLAN
  Builds with and without BUILD_TESTING

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D24554

AFFECTED FILES
  src/solid/CMakeLists.txt

To: arojas, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns