D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-21 Thread Vlad Zahorodnii
zzag added a comment.


  In D24663#549764 , @kossebau wrote:
  
  > @zzag Hi. Any chance you can have time to review this today/the WE? One of 
the last ECMGenerateExportHeader patches.
  
  
  Hi, sorry for the late response. Yes, I think this change is/was good to go.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-20 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  In D24663#550883 , @romangg wrote:
  
  > It's ok that you pushed. Can you give a link to your preferred resource for 
me to read up on ECMGenerateExportHeader? Not too comprehensive if possible.
  
  
  For one there are the API docs at 
https://api.kde.org/ecm/module/ECMGenerateExportHeader.html
  
  For the bigger picture, please see T11490 
 (also cmp. 
https://mail.kde.org/pipermail/kde-frameworks-devel/2019-October/094708.html)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-20 Thread Roman Gilg
romangg added a comment.


  It's ok that you pushed. Can you give a link to your preferred resource for 
me to read up on ECMGenerateExportHeader?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-19 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:1fb1906ac5c2: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24663?vs=67973=68320#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24663?vs=67973=68320

REVISION DETAIL
  https://phabricator.kde.org/D24663

AFFECTED FILES
  CMakeLists.txt
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/CMakeLists.txt
  src/client/outputconfiguration.h
  src/client/outputdevice.h
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.h
  src/client/xdgshell.h
  src/server/CMakeLists.txt
  src/server/outputchangeset.h
  src/server/outputdevice_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  src/server/seat_interface.h
  src/server/surface_interface.h

To: kossebau, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-19 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  Reviewed myself once more and will be pushing now, given this is fairly 
straightforward after all, so the KF_* flags can be enabled next.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  @zzag Hi. Any chance you can have time to review this today/the WE? One of 
the last ECMGenerateExportHeader patches.
  
  I would be happy if we could have all in ASAP so we can enable the KF_* 
macros and test them in git master for two weeks before 5.64 gets tagged for 
release.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-16 Thread Friedrich W. H. Kossebau
kossebau added inline comments.

INLINE COMMENTS

> zzag wrote in plasmawindowmanagement_interface.cpp:741
> Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in 
> KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file.
> 
> Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here?

KWAYLANDSERVER_BUILD_DEPRECATED_SINCE are not available yet, cmp the comment in 
the commit message:
"No support for "EXCLUDE_DEPRECATED_BEFORE_AND_AT", needs to be done by
someone with detailed knowledge about disabling implementation, if wanted."

I tried to add it, but too much API got deprecated yet still kept being used 
internally. So a version-levelled disabling of implementation is not yet 
possible, first needs more cleanup of the internal usages.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-16 Thread Vlad Zahorodnii
zzag edited reviewers, added: KWin; removed: Plasma.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin, #plasma
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-16 Thread Vlad Zahorodnii
zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:741
>  
> -#ifndef KWAYLANDSERVER_NO_DEPRECATED
>  void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop)

Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in 
KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file.

Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #plasma
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-15 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KWayland to hide deprecated API up to a given version 
or silence deprecation warnings after a given version, using
- -DKWAYLAND_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKWAYLAND_NO_DEPRECATED
- -DKWAYLAND_DEPRECATED_WARNINGS_SINCE
- -DKWAYLAND_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  
  No support for "EXCLUDE_DEPRECATED_BEFORE_AND_AT", needs to be done by
  someone with detailed knowledge about disabling implementation, if wanted.

REPOSITORY
  R127 KWayland

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24663

AFFECTED FILES
  CMakeLists.txt
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/CMakeLists.txt
  src/client/outputconfiguration.h
  src/client/outputdevice.h
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.h
  src/client/xdgshell.h
  src/server/CMakeLists.txt
  src/server/outputchangeset.h
  src/server/outputdevice_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  src/server/seat_interface.h
  src/server/surface_interface.h

To: kossebau, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns