D24667: Activate when both associatedWidget and menu are null

2019-10-15 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > kstatusnotifieritem.cpp:619 > > -if (d->associatedWidget == d->menu) { > +if (d->associatedWidget && d->associatedWidget == d->menu) { > d->statusNotifierItemDBus->ContextMenu(pos.x(), pos.y()); This should fix a situation

D24667: Activate when both associatedWidget and menu are null

2019-10-15 Thread Konrad Materka
kmaterka added a comment. This fixes issue from first comment made by @davidedmundson . Second is still not fixed. Let me copy it here: > We have one menu for the whole tray instance >

D24667: Activate when both associatedWidget and menu are null

2019-10-15 Thread Konrad Materka
kmaterka added reviewers: broulik, nicolasfella. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: Activate when both associatedWidget and menu are null

2019-10-15 Thread Konrad Materka
kmaterka created this revision. kmaterka added a reviewer: davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision. REVISION SUMMARY If associatedWidget and menu are the same then instead of "activate"