This revision was automatically updated to reflect the committed changes.
Closed by commit R296:7ede04501eda: Grab the keyboard when KeySequenceItem is
recording (authored by davidre).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24736?vs=68144&id=68960
apol accepted this revision.
REPOSITORY
R296 KDeclarative
BRANCH
grabkeyboard (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24736
To: davidre, #frameworks, davidedmundson, apol
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
apol added a comment.
+1 Makes sense to me.
REPOSITORY
R296 KDeclarative
BRANCH
grabkeyboard (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24736
To: davidre, #frameworks, davidedmundson
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
grabkeyboard (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24736
To: davidre, #frameworks, davidedmundson
Cc: broulik, kde-frameworks-devel, Le
davidre added a comment.
Ping
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D24736
To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
davidre updated this revision to Diff 68144.
davidre added a comment.
Whitespace
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24736?vs=68143&id=68144
BRANCH
grabkeyboard (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24736
davidre updated this revision to Diff 68143.
davidre added a comment.
- Make helper a qquickitem instead
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24736?vs=68142&id=68143
BRANCH
grabkeyboard (branched from master)
REVISION DETAIL
https://pha
broulik added a comment.
Alternatively you could make the `KeySequenceHelper` itself a `QQuickItem` so
it gets assigned a window.
INLINE COMMENTS
> keysequencehelper.cpp:118
> QString shortcutDisplay;
> -
> +QQuickItem* keySequenceItem;
> //! Check the key sequence against KSta
davidre added a reviewer: Frameworks.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D24736
To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.
REVISION SUMMARY
Otherwise assigning a key combination which is currently bound to a global
shortcut action will trigger the global sho
10 matches
Mail list logo
