D24746: [kpropertiesdialog] adjust ui for root directory

tienisto marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n,

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto added a comment. In D24746#549960 , @ngraham wrote: > [...] > If we improve the properties dialog for disks in general, that will also improve the display for other kinds of disks and mounted volumes. > What do you think?

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto edited the summary of this revision. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n,

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto updated this revision to Diff 68263. tienisto added a comment. show 'Mounted on' again REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24746?vs=68228=68263 BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL

D24746: [kpropertiesdialog] adjust ui for root directory

ngraham added a comment. In principle I like the idea of customizing the display to be more appropriate. However I feel like the best way to do this might be to go in a different direction: instead of adding overrides for `/`, maybe we should take advantage of the fact that `/` is always a

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto added a comment. In D24746#549637 , @meven wrote: > I would suggest keeping "Location" and "Mounted on" fields to actually display '/' to the user. To me users should know that / is the root folder and has the highest level in

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto marked an inline comment as done. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n,

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto updated this revision to Diff 68228. tienisto added a comment. use 'Unknown' instead of 'unknown' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24746?vs=68206=68228 BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL

D24746: [kpropertiesdialog] adjust ui for root directory

meven added a comment. I would suggest keeping "Location" and "Mounted on" fields to actually display '/' to the user. Especially for newbies users who might not know what "Root Directory" means. But for more advanced user it would make sense too as / is currently visible only in the

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: ahmadsamir, GB_2,

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto updated this revision to Diff 68206. tienisto added a comment. use root folder icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24746?vs=68205=68206 BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto updated this revision to Diff 68205. tienisto added a comment. cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24746?vs=68199=68205 BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto added inline comments. INLINE COMMENTS > ahmadsamir wrote in kpropertiesdialog.cpp:1172 > Probably not so obvious for new Linux users; especially those coming from > windows where things are represented as C:\, D:\ ... etc. I think new linux users don't even know what mounting means

D24746: [kpropertiesdialog] adjust ui for root directory

ahmadsamir added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1172 > > -l = new QLabel(i18n("Mounted on:"), d->m_frame); > -grid->addWidget(l, curRow, 0, Qt::AlignRight); > +// only show for non-root folders because '/' is obviously

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 added a comment. Can we also set the root folder icon? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto edited the summary of this revision. tienisto added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto created this revision. tienisto added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tienisto requested review of this revision. REVISION SUMMARY special ui changes if root directory is selected REPOSITORY R241 KIO BRANCH