D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

ngraham added a comment. You're right that the code is quite convoluted. But it would seem to make sense to fix the value there rather than conditionally overriding it later. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24941 To: meven, ngraham, #frameworks Cc:

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

meven added a comment. In D24941#553926 , @ngraham wrote: > Do we know why `d->oldname` is empty or `.` in the first place? Feels like maybe this should be fixed there. line 873 in kpropertiesdialog.cpp > // Extract the file name

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

ngraham added a comment. Do we know why `d->oldname` is empty or `.` in the first place? Feels like maybe this should be fixed there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24941 To: meven, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

meven updated this revision to Diff 68736. meven added a comment. Avoid unncessary change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24941?vs=68735=68736 BRANCH arcpatch-D24941 REVISION DETAIL https://phabricator.kde.org/D24941 AFFECTED FILES

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24941 To: meven, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

meven created this revision. meven added reviewers: ngraham, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24941