D24956: Consider desktop files with NoDisplay attribute

meven abandoned this revision. meven added a comment. D28856 should be preferred REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol, davidedmundson Cc: davidedmundson, davidre, kde-fra

D24956: Consider desktop files with NoDisplay attribute

fvogt added a comment. In D24956#648968 , @davidedmundson wrote: > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t". The UI allows you to remove that. This would remove the entry in kglob

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. In D24956#648991 , @meven wrote: > In D24956#648968 , @davidedmundson wrote: > > > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with

D24956: Consider desktop files with NoDisplay attribute

meven added a comment. In D24956#648968 , @davidedmundson wrote: > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t". The UI allows you to remove that. This would remove the entry in kglob

D24956: Consider desktop files with NoDisplay attribute

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t". The UI allows you to remove that. This would remove the entry in k

D24956: Consider desktop files with NoDisplay attribute

fvogt added a comment. In D24956#648905 , @davidedmundson wrote: > kglobalshortcutseditor.cpp > needs updating to match > > I think you're right with your reasoning about NoDisplay, but we do want something to be able to mask system files

D24956: Consider desktop files with NoDisplay attribute

davidedmundson added a comment. kglobalshortcutseditor.cpp needs updating to match I think you're right with your reasoning about NoDisplay, but we do want something to be able to mask system files. From the spec should we be checking Hidden= ? REPOSITORY R268 KGlobalAccel REVISION

D24956: Consider desktop files with NoDisplay attribute

apol added a comment. +1 This makes sense to me REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. For reference here is the relevant part in the kcm https://cgit.kde.org/plasma-desktop.git/tree/kcms/keys/kglobalshortcutseditor.cpp#n176 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol Cc:

D24956: Consider desktop files with NoDisplay attribute

meven added a comment. In D24956#554190 , @davidre wrote: > I think you have also to check the the kcm as i also saw some `nodisplay` there. > Also it seems kglobalaccel uses nodisplay when a component is disabled. https://cgit.kde.org/kgloba

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. I think you have also to check the the kcm as i also saw some `nodisplay` there. Also it seems kglobalaccel uses nodisplay when a component is disabled. https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n144 REPOSITORY R268 KGloba

D24956: Consider desktop files with NoDisplay attribute

meven added a comment. This was added previously in D2103 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

meven created this revision. meven added reviewers: mart, Plasma, fvogt, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY > NoDisplay means "this application exists, but don't display it in the