D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Saving this for later on invent.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg, ngraham
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D24975: Change some 32px action icons to color style

[Nathaniel Graham]

ngraham added a comment.


  In D24975#554805 , @ndavis wrote:
  
  > I don't have time to do all 32px icons at once, but thankfully, they're 
usually only used in the desktop shell (I can put 32px monochrome icons in the 
desktop theme), or in preferences or navigation sidebars. I suppose it also 
affects people who raise the toolbar icon size to 32px, but I wonder how many 
people even know they can do that. I could just keep this diff unlanded for as 
long as it takes to convert all 32px icons.
  
  
  That might be a good idea. We'll surely get bug reports about 
half-color/half-monochrome icons in apps that use 32px action icons for their 
own category switcher sidebars, like Okular:
  
  F7675508: Screenshot_20191027_144101.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  color32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg, ngraham
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24975: Change some 32px action icons to color style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  These look great to me.

REPOSITORY
  R266 Breeze Icons

BRANCH
  color32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg, ngraham
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a comment.


  I don't have time to do all 32px icons at once, but thankfully, they're 
usually only used in the desktop shell (I can put 32px monochrome icons in the 
desktop theme), or in preferences or navigation sidebars. I suppose it also 
affects people who raise the toolbar icon size to 32px, but I wonder how many 
people even know they can do that. I could just keep this diff unlanded for as 
long as it takes to convert all 32px icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a subscriber: ngraham.
ndavis added a comment.


  In D24975#554721 , @mglb wrote:
  
  > Why do you replace action icons instead of adding separate colorful icons 
for use in preference dialogs? Right now all action icons are "monochrome", 
making few of them colorful will introduce inconsistency.
  
  
  Maybe I should have explained it in the summary. It's kind of impossible to 
have consistent icon styles in 3rd party apps and well be breaking 
compatibility with 3rd party icon themes whenever we add another `preferences-` 
icon. @ngraham and I have talked about this and we decided that it might be 
best to just make all 32px and larger icons use the color style. In order to 
fix the problem we have without changing breeze-icons, we may need a new 
freedesktop.org icon spec that is designed to handle the type of theme we have. 
The current fd.o spec works in a way that assumes an icon theme will have one 
style. GNOME gets around that by just naming some icons symbolic, but that 
means apps have to choose to use symbolic icons. If you want more time to 
discuss changes like these and find other solutions, that's fine with me. This 
patch doesn't need to be landed in a hurry.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24975: Change some 32px action icons to color style

[Mariusz Glebocki]

mglb added a comment.


  Why do you replace action icons instead of adding separate colorful icons for 
use in preference dialogs? Right now all action icons are "monochrome", making 
few of them colorful will introduce inconsistency.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a task: T10165: Large category icons should all be colorful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  - document-open-recent, document-save-all, document-save-as, document-save, 
folder-open-recent, view-presentation, view-preview.svg

REPOSITORY
  R266 Breeze Icons

BRANCH
  color32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24975

AFFECTED FILES
  icons-dark/actions/32/document-open-recent.svg
  icons-dark/actions/32/document-save-all.svg
  icons-dark/actions/32/document-save-as.svg
  icons-dark/actions/32/document-save.svg
  icons-dark/actions/32/folder-open-recent.svg
  icons-dark/actions/32/view-presentation.svg
  icons-dark/actions/32/view-preview.svg
  icons/actions/32/document-open-recent.svg
  icons/actions/32/document-save-all.svg
  icons/actions/32/document-save-as.svg
  icons/actions/32/document-save.svg
  icons/actions/32/folder-open-recent.svg
  icons/actions/32/view-presentation.svg
  icons/actions/32/view-preview.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns