nibags closed this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D24983
To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
nibags updated this revision to Diff 69150.
nibags added a comment.
- Increase the menu size according to the font size, to improve the display
This achieves a better visualization if the user increases the font size in
the Plasma preferences.
REPOSITORY
R39 KTextEditor
CHANGES SINCE
nibags updated this revision to Diff 69022.
nibags added a comment.
- Increase margin of list - search bar in Windows
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24983?vs=69005=69022
BRANCH
improve-word-wrap
REVISION DETAIL
nibags updated this revision to Diff 69005.
nibags added a comment.
- Restore scroll bar margins
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24983?vs=68974=69005
BRANCH
improve-word-wrap
REVISION DETAIL
https://phabricator.kde.org/D24983
nibags updated this revision to Diff 68974.
nibags added a comment.
- Fix font size/style
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24983?vs=68828=68974
BRANCH
improve-word-wrap
REVISION DETAIL
https://phabricator.kde.org/D24983
AFFECTED
dhaumann added a comment.
Good, fine with me.
Related: Maybe the translation should also be shorter, but the general
possible problem persists. Please go ahead.
REPOSITORY
R39 KTextEditor
BRANCH
improve-word-wrap
REVISION DETAIL
https://phabricator.kde.org/D24983
To: nibags,
nibags added a comment.
`QFontMetrics::boundingRect(text).width()` doesn't deliver an exact value of
the text width, since I detected that in some translations and some desktop
themes the text goes below the scroll bar. This problem doesn't exist with
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
It's hard to review all the pixel changes with no screenshots. It's even
unclear to me what problem exactly is fixed at hand. Given it's all your code,
I trust you know what you are
nibags updated this revision to Diff 68828.
nibags added a comment.
- Fixes
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24983?vs=68827=68828
BRANCH
improve-word-wrap
REVISION DETAIL
https://phabricator.kde.org/D24983
AFFECTED FILES
nibags created this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
REVISION SUMMARY
- Use `QFontMetrics::horizontalAdvance(text)`
10 matches
Mail list logo