This revision was automatically updated to reflect the committed changes.
Closed by commit R295:4dc999b9eba1: Make KCModuleQml conform to the defaulted()
signal (authored by ervin).
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25070?vs=69040=69272
ngraham edited the summary of this revision.
ngraham added a dependency: D25069: Adjust KCModule to also channel information
about defaults.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D25070
To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure
Cc:
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D25070
To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
ervin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kcmoduleqml.cpp:80-82
> needsSave emits the current state and then connects for changes
> representsDefaults only connects for changes
>
> I would expect them to match as they're doing equivalent things.
>
> It looks to me
davidedmundson added inline comments.
INLINE COMMENTS
> kcmoduleqml.cpp:80-82
> if (d->configModule->needsSave()) {
> emit changed(true);
> }
needsSave emits the current state and then connects for changes
representsDefaults only connects for changes
I would expect them to
ervin created this revision.
ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.
REVISION SUMMARY
This new signal got introduced in KCModule, so we
