D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

2020-04-24 Thread Méven Car
meven abandoned this revision. meven added a comment. D28856 should be preferred REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D25088 To: meven, #plasma, broulik, apol Cc: davidre, davidedmundson, kde-frameworks-devel,

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

2019-10-31 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > kserviceactioncomponent.cpp:36 > m_serviceStorageId(serviceStorageId), > > m_desktopFile(QStandardPaths::locate(QStandardPaths::GenericDataLocation, > QStringLiteral("kglobalaccel/") + serviceStorageId)) > { Related to

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

2019-10-31 Thread Méven Car
meven added inline comments. INLINE COMMENTS > davidedmundson wrote in kserviceactioncomponent.cpp:36 > I don't think I follow. > > We're editing the .desktop file inside > {XDG_DATA_DIRS}/kglobalaccel/someName.desktop > The menu only reads from XDG_DATA_DIRS/applications/someName.desktop > >

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

2019-10-31 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > kserviceactioncomponent.cpp:36 > m_serviceStorageId(serviceStorageId), > > m_desktopFile(QStandardPaths::locate(QStandardPaths::GenericDataLocation, > QStringLiteral("kglobalaccel/") + serviceStorageId)) > { I

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

2019-10-31 Thread Méven Car
meven created this revision. meven added reviewers: Plasma, broulik, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Needed to allow apps to not be visible in menus but have shortcuts (i.e