D25152: Reenable the tests and only disable krcrashtest on windows

2019-11-05 Thread Ahmad Samir
ahmadsamir added a comment. In D25152#558886 , @sitter wrote: > Heh, sorry  Don't be sorry, yours is actually a fix, mine isn't/wasn't :D > D25153 for reference. REPOSITORY R285 KCrash

D25152: Reenable the tests and only disable krcrashtest on windows

2019-11-05 Thread Harald Sitter
sitter added a comment. Heh, sorry  D25153 for reference. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D25152 To: ahmadsamir, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25152: Reenable the tests and only disable krcrashtest on windows

2019-11-05 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. @sitter: I see you have a fix already :) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D25152 To: ahmadsamir, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25152: Reenable the tests and only disable krcrashtest on windows

2019-11-05 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN Code builds and tests pass on Linux REPOSITORY R285 KCrash BRANCH l-win-test (branched from master) REVISION