D25219: Only create a session config when actually restoring a session

2019-11-26 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:23d4f14601fd: Only create a session config when actually 
restoring a session (authored by ngraham).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25219?vs=70054&id=70352

REVISION DETAIL
  https://phabricator.kde.org/D25219

AFFECTED FILES
  src/gui/kconfiggui.cpp

To: ngraham, #frameworks, davidedmundson
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25219: Only create a session config when actually restoring a session

2019-11-26 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  session-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25219: Only create a session config when actually restoring a session

2019-11-20 Thread Nathaniel Graham 
ngraham updated this revision to Diff 70054.
ngraham marked an inline comment as done.
ngraham added a comment.


  Check for `sessionConfig()` being nullptr

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25219?vs=69464&id=70054

BRANCH
  session-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25219

AFFECTED FILES
  src/gui/kconfiggui.cpp

To: ngraham, #frameworks, davidedmundson
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25219: Only create a session config when actually restoring a session

2019-11-19 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> kconfiggui.cpp:73
>  {
>  return sessionConfig()->name();
>  }

sessionConfig() can be nullptr can you add a check.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25219: Only create a session config when actually restoring a session

2019-11-19 Thread Nathaniel Graham 
ngraham added a comment.


  Can I get a review on this?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Only create a session config when actually restoring a session

2019-11-16 Thread Nathaniel Graham 
ngraham added a comment.


  Ping.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Only create a session config when actually restoring a session

2019-11-08 Thread Nathaniel Graham 
ngraham added a dependent revision: D11382: Add an option to show tabs from 
last time when Dolphin starts.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Only create a session config when actually restoring a session

2019-11-08 Thread Nathaniel Graham 
ngraham retitled this revision from "Also only create a session config when 
actually restoring a session" to "Only create a session config when actually 
restoring a session".

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns